Remove unix dependency in irmin-test#1860
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 63.97% 63.96% -0.01%
==========================================
Files 129 129
Lines 15479 15475 -4
==========================================
- Hits 9902 9899 -3
+ Misses 5577 5576 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
6daceb9 to
c51db10
Compare
|
@patricoferris could you rebase your PR? That seems like a very good change, I'm happy to have it in the next irmin release :-) |
|
(it also seems related to @metanivek's #1948) |
|
@patricoferris my recent changes did touch similar files as this PR but looking at the conflicting files I think the only thing you need to know is that you can delete the |
Co-authored-by: Ioana Cristescu <ioana@tarides.com>
c51db10 to
e897241
Compare
Great, all rebased :)) |
|
Thanks! |
This PR removes the
lwt.unixdependency inirmin-testallowing the test-suite package to be compiled into more exotic locations (the browser, unikernels etc.).This is how we managed to test the irmin-server port to use websockets so the client could be in the browser. I then tested a few different backends (an updated irmin-indexeddb and
irmin.mem) using the testsuite in this repository with a live version available.Note this PR, in order to run in the browser, requires mirage/alcotest#348.