feat: Resolve node references in preview.text expressions#44
Open
gradinarufelix wants to merge 2 commits intomireo91:masterfrom
Open
feat: Resolve node references in preview.text expressions#44gradinarufelix wants to merge 2 commits intomireo91:masterfrom
gradinarufelix wants to merge 2 commits intomireo91:masterfrom
Conversation
Add support for accessing properties of referenced nodes in preview.text
and preview.image expressions. Previously, reference type properties only
exposed the node identifier (UUID). Now they expose a resolved object with
the node's properties, label, and metadata.
Changes:
- Add ReferenceResolverSource.php DataSource for resolving node references
- Add resolvedReferences state in index.jsx (isolated from currentValue)
- Modify getPreview() to create temporary enriched item for preview only
Usage:
preview:
text: 'ItemEval: item.person?.properties?.firstName'
The changes are strictly scoped to preview functionality:
- currentValue is never modified
- Editors continue receiving original node identifier strings
- Data commits send original node identifiers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for accessing properties of referenced nodes in preview.text and preview.image expressions. Previously, reference type properties only exposed the node identifier (UUID). Now they expose a resolved object with the node's properties, label, and metadata.
Changes:
Usage:
preview: text: 'ItemEval: item.person?.properties?.firstName'
The changes are strictly scoped to preview functionality:
Extends #41