feat(ui): UIPage.Route (was Slug) + drop UIPage.Icon + WebDir static handler#104
Merged
Conversation
…handler
Pre-compact in-flight: brings UIPage's URL field in line with the
catch-all page on the platform side (route-segment shape, "/" for
index) instead of the bare slug shape, and drops the per-page Icon
in favor of Config.Icon (one icon per module, set on the nav rail).
- Rename UIPage.Slug → UIPage.Route. Route is a full path-from-root
("/", "/users", "/settings/audit") matching the segments the
platform's [[...page]] catch-all sees. Validation moves to per-
segment checks against the same regex.
- Drop UIPage.Icon. Per-page icons aren't surfaced anywhere in the
platform today; Config.Icon is the source of truth for the nav rail.
- New system.WebHandler + Config.WebDir: SDK serves the module's
React bundle directory at /__mirrorstack/web/* (CORS open) so the
platform's ModuleMount can dynamic-import a stable URL. Path-
traversal guarded by EvalSymlinks on both root and target.
Tests updated for the rename + new web handler. Whole-repo tests
clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-compact in-flight work. Brings UIPage's URL field in line with the catch-all page on the platform side (route-segment shape, `"/"` for index) instead of the bare slug shape, and drops the per-page Icon in favor of `Config.Icon` (one icon per module, set on the nav rail).
This PR is a dependency of #103 (PlatformAuth) — both ship at the same time so ms-app-modules consumers can pick up a coherent SDK. The two PRs touch disjoint files but oauth-core needs both.
Changes
Test plan
🤖 Generated with Claude Code