refactor(auth): extract rejectNotProxied helper in requireProxy#118
Closed
I-am-nothing wants to merge 1 commit into
Closed
refactor(auth): extract rejectNotProxied helper in requireProxy#118I-am-nothing wants to merge 1 commit into
I-am-nothing wants to merge 1 commit into
Conversation
Both failure paths in requireProxy (unreadable token source and token mismatch) wrote the same httputil.JSON 403/not_proxied response inline. Extract rejectNotProxied() so the response body is defined once; the distinct log.Printf calls before each site are preserved for per-path diagnostics. No behavior change. go test ./auth/... ./internal/core/... green.
Contributor
Author
|
Folded into #119 (the rejectNotProxied dedup is included there). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireProxy(unreadable token source and token mismatch) wrote an identicalhttputil.JSON403/not_proxiedresponse inline — duplicated across 8 linesrejectNotProxied(w)so the response body is defined once; the distinctlog.Printfcalls before each site are preserved for per-path diagnosticsgo test ./auth/... ./internal/core/...green/simplify pass on PR #117 (
feat/require-proxy-token).🤖 Generated with Claude Code