Skip to content

fix(db): make Resources.DB sslmode configurable (dev-sim TLS) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
I-am-nothing merged 1 commit into from
Jul 3, 2026
Merged

fix(db): make Resources.DB sslmode configurable (dev-sim TLS) #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions db/pool_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package db
import (
"context"
"fmt"
"os"
"time"

"github.com/jackc/pgx/v5"
Expand Down Expand Up @@ -72,9 +73,16 @@ func configurePoolDefaults(cfg *pgxpool.Config) {
func createPool(ctx context.Context, cred Credential) (*pgxpool.Pool, error) {
// DSN intentionally excludes the password — any wrapped ParseConfig error
// would otherwise echo the full connection string into CloudWatch.
// sslmode defaults to require (prod: the RDS Proxy endpoint mandates TLS);
// a local dev-sim Postgres has no TLS, so the dev runner sets
// MS_MODULE_DB_SSLMODE=disable. Unset always resolves to the secure default.
sslmode := os.Getenv("MS_MODULE_DB_SSLMODE")
if sslmode == "" {
sslmode = "require"
}
connStr := fmt.Sprintf(
"host=%s port=%d dbname=%s user=%s sslmode=require",
cred.Host, cred.Port, cred.Database, cred.Username,
"host=%s port=%d dbname=%s user=%s sslmode=%s",
cred.Host, cred.Port, cred.Database, cred.Username, sslmode,
)
cfg, err := pgxpool.ParseConfig(connStr)
if err != nil {
Expand Down
Loading