feat: emit X-MS-Manifest-Hash from the module manifest endpoint#142
Open
I-am-nothing wants to merge 1 commit into
Open
feat: emit X-MS-Manifest-Hash from the module manifest endpoint#142I-am-nothing wants to merge 1 commit into
I-am-nothing wants to merge 1 commit into
Conversation
The manifest endpoint now stamps X-MS-Manifest-Hash = hex(sha256(served body)) on its response — the single source of truth for a module's Go-declared manifest hash. The platform and CLI both READ this header (never recompute), so their hashes can never disagree. The hash reflects the declared surface (pages/permissions/schedules/migrations/...) and is stable across esbuild JS rebuilds (the manifest body carries no JS). The body is encoded exactly as before (httputil.JSON's HTML-escaping encoder + trailing newline) and hashed over those same bytes, so the served manifest stays byte-identical. Header-only (not in the body → no self-reference). Additive wire change; old readers ignore it. Part of the 3-repo manifest hash-beat (api-platform + mirrorstack-cli). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: emit X-MS-Manifest-Hash from the module manifest endpoint
The manifest endpoint now stamps X-MS-Manifest-Hash = hex(sha256(served body))
on its response — the single source of truth for a module's Go-declared manifest
hash. The platform and CLI both READ this header (never recompute), so their
hashes can never disagree. The hash reflects the declared surface
(pages/permissions/schedules/migrations/...) and is stable across esbuild JS
rebuilds (the manifest body carries no JS).
The body is encoded exactly as before (httputil.JSON's HTML-escaping encoder +
trailing newline) and hashed over those same bytes, so the served manifest stays
byte-identical. Header-only (not in the body → no self-reference). Additive wire
change; old readers ignore it.
Part of the 3-repo manifest hash-beat (api-platform + mirrorstack-cli).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com