feat(DropdownMenu): custom icon nodes + external-link items#315
Merged
Conversation
Items could only take a Material Symbols icon NAME, so a brand logo (e.g. GitHub's mark, which Material Symbols doesn't ship) couldn't be used. Allow `icon` to be a ReactNode as well, rendered in place of `<Icon>`. Add `external?: boolean` on an item to render a trailing open-in-new glyph as the affordance for items that open in a new tab (performing the navigation stays the caller's job in onSelect). Backward-compatible: string icons render exactly as before, and items without `external` are unchanged. Adds a CustomIconAndExternal story. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Storybook Preview: https://mirrorstack-ai.github.io/web-ui-kit/pr/315/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DropdownMenuitems could only take a Material Symbols icon name and had no way to indicate they open externally. This adds both, so a nav "more" menu can show a real brand logo and mark its external links:iconaccepts a custom node. Material Symbols ships no brand logos (GitHub, etc.), soicon?: string | ReactNode— a string is still rendered via<Icon>; a node is rendered as-is (size it to ~the item icon size and usecurrentColorto inherit the muted colour).external?: booleanrenders a trailing open-in-new glyph as the affordance for items that open in a new tab. Performing the navigation stays the caller's job inonSelect.Backward-compat
externalare unchanged. No behaviour change for existing callers; existing tests pass untouched.CustomIconAndExternalstory.Versioning
releaselabel applied so the release workflow publishes on merge.Adoption
🤖 Generated with Claude Code