feat(TrendChart): shared multi-series trend chart component#329
Merged
Conversation
Extracts a real-pixel-plotted trend chart (solid line/area + N dashed overlay series, optional threshold line, optional x-axis labels, hover tooltip) into a single shared block component, replacing two independent near-duplicate private Chart implementations in web-applications (dev/module/[slug]/service/page.tsx and the new app debug page's services-status-tab.tsx). Fixes a latent bug from one of those private copies along the way: an overlay's tooltip unit was inferred from whether fixedMax was set (fixedMax != null ? "%" : unit), conflating "has a pinned y-axis ceiling" with "is a percentage" — TrendChartOverlay.unit is now explicit and independent of fixedMax. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Storybook Preview: https://mirrorstack-ai.github.io/web-ui-kit/pr/329/ |
I-am-nothing
added a commit
that referenced
this pull request
Jul 3, 2026
main already published 0.6.2 via #329 (an independent branch that merged directly to main before this one did), so this branch's own 0.6.2 would collide — no version diff for the release automation to act on when this merges. Bumping to 0.6.3 so merging this branch actually publishes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts a real-pixel-plotted trend chart (solid line/area + N dashed overlay series, optional threshold line, optional x-axis labels, hover tooltip) into a single shared
TrendChartblock component, replacing two independent near-duplicate privateChartimplementations in web-applications.Also fixes a latent bug carried over from one of those private copies: an overlay's tooltip unit was inferred from whether
fixedMaxwas set (fixedMax != null ? "%" : unit), conflating "has a pinned y-axis ceiling" with "is a percentage".TrendChartOverlay.unitis now explicit and independent offixedMax.Note on versioning
This bumps to
0.6.2, same as the independent, already-open #328. Whichever of the two merges second will need a rebase + re-bump to0.6.3to avoid a version collision — flagging since it depends on merge order.Test plan
pnpm typecheck/pnpm buildcleanpnpm test— 797/797 pass (incl. 10 new TrendChart tests)🤖 Generated with Claude Code