Open
Conversation
- Add ClientFactory interface to create per-cluster Incus clients - Update IncusMachineReconciler to use ClientFactory instead of single client - Read connection configuration from cluster's secret reference - Support TLS certificates, CA, and insecure skip verify options - Handle project configuration from cluster spec - Clean up unused global Incus connection code in main.go Each IncusCluster can now specify its own Incus endpoint, project, and credentials, allowing the provider to manage machines across multiple Incus servers and projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Technical Details
pkg/incus/client_factory.go: New factory interface and implementationIncusMachineReconciler: Updated to use factory instead of single clientmain.go: Removed global Incus connection setuptls-ca,tls-client-cert,tls-client-key,insecure-skip-verifyTest Plan
This enables the provider to manage machines across multiple Incus servers and projects simultaneously.