Change BlockSvg.select to Blockly.common.setSelected

[mjgallag]

RaspberryPiFoundation/blockly#7991

[mjgallag]

@mark-friedman this code is not currently active in this plugin but is active in App Inventor so wanted to keep it synced. No release is required. To test you need to enable procedure blocks and hook up the Highlight Procedure context menu item, see below:


I figure someone might use this code to implement Highlight Function someday so best it works :)

[mark-friedman]

For convenience, and because I just spent 1/2 hour trying to figure out what was going on, would you mind making the change from procCustomContextMenu to customContextMenu in this PR?

[mjgallag]

@mark-friedman sure, will do right now, I only didn't because I was unsure if there was a reason for it that I didn't understand ha.

[mjgallag]

@mark-friedman done. And just to be clear, the error condition was that before this fix both procedure call and procedure get selected ... if you look at the pr referenced in my original commit this was interestingly to help support multiselect.

[mjgallag]

@mark-friedman just tweaked it to rename function as well so it matched up with the others.

[mjgallag]

That is also how it looks in App Inventor master, no proc in both places.

[mark-friedman]

That is also how it looks in App Inventor master, no proc in both places.

Yes, that was part of the "research" that I did to try and understand what was going on, and discovered that that was something that was changed in App Inventor back in January but wasn't synced with the plugin.