Refresh CLAUDE.md after the dependency cleanup - #67
Merged
Conversation
PR #66 left two notes factually wrong: the build no longer uses copyfiles, and the nested copyfiles -> minimatch -> brace-expansion override no longer exists. Both are corrected, and the header now says TypeScript 7 / Cucumber 13 rather than predating those majors. Adds two notes worth having: - PR CI never builds the Docker image — both publish workflows trigger only on `v*` tags, so a broken Dockerfile or build script stays invisible until release. This was a real gap: #66 changed the build step and nothing in PR CI would have caught a container-level break. - Keep install output warning-free, and fix causes rather than hiding them behind --silent or a redirect. Also documents that an override can be scoped to a single dependent (swagger-jsdoc -> glob), with the reasoning that makes that one safe. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #66 left two notes in
CLAUDE.mdfactually wrong. This corrects them and adds two gaps worth recording.Corrections
tsc+copyfilestsc+scripts/copy-yaml.mjs(copyfiles was removed in #66)copyfiles → minimatch → brace-expansionentryswagger-jsdoc → globoverride insteadNew notes
PR CI never builds the Docker image. Both publish workflows trigger only on
v*tags, so a brokenDockerfileor build script stays invisible until release. This was a real gap, not a hypothetical — #66 changed the build step, and nothing in PR CI would have caught a container-level break. The note says to rundocker build .locally before tagging whenever the build pipeline changes.Keep install output warning-free. A cold
npm cicurrently emits zeronpm warn deprecatedlines; the note is to keep it that way and fix causes rather than hide them behind--silentor a redirect.Every claim was verified against the tree:
typescript@^7.0.2,@cucumber/cucumber@^13.2.0, the build script, theoverridesblock,copyfilesabsent,scripts/copy-yaml.mjspresent, and both docker workflows'on: push: tags: v*triggers.Docs only.
🤖 Generated with Claude Code