Skip to content

Release 0.66.0#3289

Closed
odlbot wants to merge 9 commits into
releasefrom
release-candidate
Closed

Release 0.66.0#3289
odlbot wants to merge 9 commits into
releasefrom
release-candidate

Conversation

@odlbot
Copy link
Copy Markdown
Contributor

@odlbot odlbot commented May 4, 2026

Chris Chudzicki

Carey P Gumaer

Ahtesham Quraish

Shankar Ambady

shanbady and others added 9 commits May 1, 2026 15:37
* adding buckets for dynamic optimizer settings

* fix test

* add test

* Update vector_search/conftest.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* skip if already optimized

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ideo series page and change the title of video and playlist on drawer (#3270)

* fix: remove duration and institution label from the video series page



---------

Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.1.14>
#3253 was merged with stale CI from before #3269 changed
getTitle to use run.title for CourseRunEnrollment. The new
heading-level assertion still expected course.title.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* set s-maxage via NEXT_CACHE_S_MAXAGE_SECONDS

* allow empty
* fix fallback when no language is selected

Co-authored-by: Copilot <copilot@github.com>

* remove dead code

Co-authored-by: Copilot <copilot@github.com>

* add a test that ensures the cta is disabled if there are no enrollable runs

---------

Co-authored-by: Copilot <copilot@github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

OpenAPI Changes

No changes detected

View full changelog

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

Comment thread vector_search/utils.py
Comment on lines +142 to +144
def compute_optimizer_settings(point_count: int, shard_number: int):
points_per_shard = max(point_count // shard_number, 1)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The function compute_optimizer_settings may cause a TypeError due to integer division with a None value for point_count when a new, empty collection is created.
Severity: CRITICAL

Suggested Fix

In tune_collection, check if point_count is None after retrieving it from the Qdrant client. If it is None, default it to 0 before passing it to compute_optimizer_settings to prevent the TypeError.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: vector_search/utils.py#L142-L144

Potential issue: The function `compute_optimizer_settings` performs integer division
`point_count // shard_number` without checking if `point_count` is `None`. The calling
function `tune_collection` gets `points_count` from the Qdrant client, which is typed as
`Optional[int]` and returns `None` for newly created empty collections. This will raise
a `TypeError` when `tune_collection` is called after creating a new collection (e.g., on
first deployment or with `force_recreate=True`), crashing the `create_qdrant_collection`
process.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants