Release 0.66.2#3294
Merged
Merged
Conversation
* adding buckets for dynamic optimizer settings * fix test * add test * Update vector_search/conftest.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * skip if already optimized --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ideo series page and change the title of video and playlist on drawer (#3270) * fix: remove duration and institution label from the video series page --------- Co-authored-by: Ahtesham Quraish <ahtesham.quraish@192.168.1.14>
* set s-maxage via NEXT_CACHE_S_MAXAGE_SECONDS * allow empty
* fix fallback when no language is selected Co-authored-by: Copilot <copilot@github.com> * remove dead code Co-authored-by: Copilot <copilot@github.com> * add a test that ensures the cta is disabled if there are no enrollable runs --------- Co-authored-by: Copilot <copilot@github.com>
…guage run (#3291) When a contract has both an old and a new run of the same course (same language) and the user is enrolled in the older one, the dashboard was hiding their enrollment because language resolution defaulted to `course.next_run_id` (the newer, unenrolled run). Add `selectBestContractEnrollmentForLanguage` to find the user's best existing enrollment for the selected language (by language_options id / courseware_id, regardless of `is_enrollable`), and call it from both B2B paths in ContractContent before falling back to the next/best run. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* add fallback to handle no matching language case Co-authored-by: Copilot <copilot@github.com> * fall back to best enrollment selection if no language is present in any runs Co-authored-by: Copilot <copilot@github.com> * handle missing language on course 1, set language on course 2 Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Copilot <copilot@github.com>
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
200
to
208
| tab.data.params.id, | ||
| ) as CarouselQuery | ||
| case "lr_vector_similar": | ||
| return learningResourceQueries.vectorSimilar( | ||
| tab.data.params.id, | ||
| ) as CarouselQuery | ||
| return learningResourceQueries.vectorSimilar({ | ||
| id: tab.data.params.id, | ||
| }) as CarouselQuery | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Bug: The ResourceCarousel component for lr_vector_similar tabs only passes the id parameter to the query, ignoring other parameters like limit or resource_type.
Severity: MEDIUM
Suggested Fix
Update the lr_vector_similar case in ResourceCarousel.tsx to pass the entire tab.data.params object to the learningResourceQueries.vectorSimilar function, consistent with how other tab types are handled. Specifically, change learningResourceQueries.vectorSimilar({ id: tab.data.params.id }) to learningResourceQueries.vectorSimilar(tab.data.params).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
frontends/main/src/page-components/ResourceCarousel/ResourceCarousel.tsx#L200-L208
Potential issue: When the `ResourceCarousel` component handles a tab of type
`lr_vector_similar`, it incorrectly constructs a new object for the query parameters,
including only the `id` from `tab.data.params`. This causes any other parameters, such
as `limit` or `resource_type`, to be silently dropped. For example,
`LearningResourceDrawer.tsx` attempts to set a `limit`, but this setting is ignored.
While the current backend default limit happens to match the intended limit, any future
changes to the limit or attempts to filter by `resource_type` will not work as expected.
Did we get this right? 👍 / 👎 to inform future reviews.
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carey P Gumaer
Chris Chudzicki
Ahtesham Quraish
Shankar Ambady