-
Notifications
You must be signed in to change notification settings - Fork 3
Release 0.66.11 #3325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release 0.66.11 #3325
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ed5bdfb
feat: Welcome to learn email on new account setup (#3189)
zamanafzal ae5d5a0
Both ETL and webhook should populate OVS resource_category when appli…
mbertrand eb9dfb6
fix: update metadata for video pages (#3310)
ahtesham-quraish 469e273
refactor ocw video etl (#3308)
abeglova 1bf705f
translations UI design revisions (#3314)
gumaerc 18f2068
feat: added module section on course product page (#3242)
zamanafzal 8e6731b
fix: change the video detail page route & load more videos feature on…
ahtesham-quraish 5527b73
video ui tweaks (#3322)
abeglova 6b58829
fix flaky test (#3319)
abeglova 2ec9404
Release 0.66.11
odlbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,13 @@ | ||
| import { coursesQueries } from "./queries" | ||
| import type { | ||
| CourseOutlineModule, | ||
| CourseOutlineModuleCounts, | ||
| CourseOutlineResponse, | ||
| } from "./queries" | ||
|
|
||
| export { coursesQueries } | ||
| export type { | ||
| CourseOutlineModule, | ||
| CourseOutlineModuleCounts, | ||
| CourseOutlineResponse, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
create_userfunction callsensure_profiletwice for new users: once directly and again via anon_commithook, causing a redundant database write.Severity: LOW
Suggested Fix
Remove the direct, synchronous call to
profile_api.ensure_profile(user, profile_data=profile_data)from thecreate_userfunction. The profile creation should be handled exclusively by theon_commithook (user_created_actions) to ensure it is only called once after the user is successfully saved to the database.Prompt for AI Agent
Also affects:
profiles/plugins.py:12~21profiles/api.py:13~22Did we get this right? 👍 / 👎 to inform future reviews.