feat: add video embed page and route group restructure#3327
Open
daniellefrappier18 wants to merge 24 commits into
Open
feat: add video embed page and route group restructure#3327daniellefrappier18 wants to merge 24 commits into
daniellefrappier18 wants to merge 24 commits into
Conversation
7a76aa0 to
d7b8490
Compare
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
removed video-playlist-page from FF and as a guard on video pages
ChristopherChudzicki
requested changes
May 15, 2026
Comment on lines
-18
to
-20
| export const metadata = { | ||
| title: "Error", | ||
| } |
Contributor
There was a problem hiding this comment.
I was confused why this was removed.
For posterity... error.tsx becomes an ErrorBoundary, and error boundaries are always client components. https://nextjs.org/docs/app/getting-started/error-handling#nested-error-boundaries
And client components can't set metadata, so this was useless all along.
not-found.tsx is NOT converted into an error boundary by nextjs, it's explicitly triggered via notFound or missng routes on server render, so it's different.
Contributor
Author
There was a problem hiding this comment.
This appears to be dead code so I was just cleaning it up. Is there a reason to keep this that I'm not aware of?
Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/11123
Description (What does it do?)
Screenshots (if appropriate):
Video Embed Page with valid id (not YouTube)


http://open.odl.local:8062/video/115203/embed
Video Embed 404 Page with NON valid id (not YouTube)
http://open.odl.local:8062/video/000/embed
Video Embed Page with a valid YouTube id

Video Embed Page with non-404 error
I just added
throw new Error("test error")temporarily to VideoEmbedPage.tsx to simulateconst VideoEmbedPage: React.FC<VideoEmbedPageProps> = ({ videoId }) => { throw new Error("test error") // ← here, remove after testing const { data: resource, isLoading } = useLearningResourcesDetail(videoId) ...Regular non video embed page that doesn't exist
http://open.odl.local:8062/this-does-not-exist
Existing site route page

http://open.odl.local:8062/search?q=
How can this be tested?
Additional Context