refactor: make internal editor code more generic#3344
Open
ahtesham-quraish wants to merge 1 commit into
Open
Conversation
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11232
Description (What does it do?)
Step 2: Frontend editor refactor (Second PR)
Make
page-components/TiptapEditor/content-type-agnostic. Success looks like:/newspages./articlesthat mirrors/newsfor now, with minimal themeing changes. More changes to come, but start similar.Screenshots (if appropriate):
How can this be tested?
For testing you need to first take pull of this branch and then run the containers like web and celery and frontend, then you need to visit the following url
http://open.odl.local:8062/news/new, you first create the article and check if the request is being made tohttp://api.open.odl.local:8065/api/v1/website_content/url, basically, you need to test every corner of the articles CRUD and verify everything looks good.You should keep in mind that when article is created then celery task is run which sync the article to news, so It should run to and you will be able to see the all the articles using the following url
http://open.odl.local:8062/newsAdditional Context