Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
4fcf3a7 to
2c748f8
Compare
a9c3d00 to
376898b
Compare
d9b4789 to
35cd8b1
Compare
rhysyngsun
left a comment
There was a problem hiding this comment.
Code review, will test shortly.
| CheckConstraint( | ||
| name="courses_programrequirement_node_check", | ||
| check=( | ||
| condition=( |
There was a problem hiding this comment.
There are 2 migrations - 0022 and 0063 that are still using check=
| "deepdiff>=8.0.0,<9", | ||
| "dj-database-url>=0.5.0,<0.6", | ||
| "django==5.1.15", | ||
| "django==5.2", |
There was a problem hiding this comment.
I think going forward it might be better to have this be defined as a constraint within a minor version, so django>=5.2,<5.3. That way whenever a new patch comes down only the lockfile needs to be updated.
Anas12091101
left a comment
There was a problem hiding this comment.
I started reviewing this, but I see Nathan has already provided feedback and is testing it. I just have one small question; otherwise, I’ll leave the rest to him:
| async def aprocess_request(self, request): | ||
| # Call the sync version for compatibility | ||
| return self.process_request(request) | ||
|
|
There was a problem hiding this comment.
Why was this method added, and how is it expected to be invoked? I don’t think aprocess_request is a recognized hook in Django middleware.
There was a problem hiding this comment.
Good catch, I agree, I think it's something specific to RemoteUserMiddleware , it looks like MiddlewareMixin just calls sync_to_async on process_request() anyway: https://github.com/django/django/blob/stable/5.2.x/django/utils/deprecation.py#L125-L142
for more information, see https://pre-commit.ci
What are the relevant tickets?
Fix https://github.com/mitodl/hq/issues/8953
Description (What does it do?)
How can this be tested?
everything should work as expected