Release 1.145.1#3468
Merged
Merged
Conversation
Co-authored-by: Asad Ali <asad.ali@arbisoft.com>
odlbot
force-pushed
the
release-candidate
branch
from
fd1b6b4 to
1d22914
Compare
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+249
to
+255
| return Response( | ||
| ManagerEnrollmentCodeSerializer( | ||
| [discounts.order_by("id").first()], | ||
| context={"contract": contract}, | ||
| many=True, | ||
| ).data | ||
| ) |
There was a problem hiding this comment.
Bug: The codes action can pass [None] to the serializer if a contract has no discount codes, causing an AttributeError when the serializer tries to access an attribute on None.
Severity: HIGH
Suggested Fix
Add a check to handle the case where discounts.order_by("id").first() returns None. Instead of passing [None] to the serializer, return a response with an empty list [] to represent the absence of codes, which the serializer can handle gracefully.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: b2b/views/v0/manager.py#L249-L255
Potential issue: In the `codes` action of `ManagerContractViewSet`, if a contract has no
learner limit (`max_learners` is falsy) and no associated discount codes, the query
`discounts.order_by("id").first()` returns `None`. This `None` value is then wrapped in
a list and passed to `ManagerEnrollmentCodeSerializer` with `many=True`. The serializer
will then raise an `AttributeError` when it attempts to access an attribute like
`discount_code` on the `None` object, causing the endpoint to crash.
Did we get this right? 👍 / 👎 to inform future reviews.
Comment on lines
+146
to
+150
| .filter( | ||
| organization__organization_users__user=self.request.user, | ||
| organization__organization_users__is_manager=True, | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Bug: The get_queryset in ManagerContractViewSet incorrectly filters out contracts for superusers because it lacks a bypass, even though the permission class grants them access.
Severity: MEDIUM
Suggested Fix
Update ManagerContractViewSet.get_queryset to include a bypass for superusers, similar to the logic in ManagerOrganizationViewSet. If self.request.user.is_superuser is true, return the unfiltered queryset; otherwise, apply the existing filter for regular managers.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: b2b/views/v0/manager.py#L146-L150
Potential issue: The `get_queryset` method in `ManagerContractViewSet` unconditionally
filters contracts to only those where the requesting user is an organization manager.
However, the `IsOrganizationManager` permission class explicitly allows superusers. This
creates a mismatch where a superuser is granted permission but the queryset returns no
results if they are not also explicitly a manager of the organization. This prevents
superusers from viewing contracts they should have access to, unlike in the
`ManagerOrganizationViewSet` which correctly bypasses this filter for superusers.
Did we get this right? 👍 / 👎 to inform future reviews.
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nathan Levesque
James Kachel
annagav
Asad Ali