Open
Conversation
Add validation to ensure MIN_NUMBER_OF operator values are numeric and >= 1. In courses/forms.py: add a minimum: 1 to the schema default, enforce presence and numeric/positive checks in ProgramAdminForm._validate_elective_value_presence, and fix a traversal bug to check the child's operator field. In courses/models.py: add ProgramRequirement.clean() to validate operator_value at the model level and raise descriptive ValidationError messages for non-numeric or <1 values. These changes prevent invalid/negative elective minimums at both form and model layers.
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
for more information, see https://pre-commit.ci
…um-of' of https://github.com/mitodl/mitxonline into 11010-program-req_tree-allows-negative-numbers-in-minimum-of
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/11010
Description (What does it do?)
Add validation to ensure MIN_NUMBER_OF operator values are numeric and >= 1. In courses/forms.py: add a minimum: 1 to the schema default, enforce presence and numeric/positive checks in ProgramAdminForm._validate_elective_value_presence, and fix a traversal bug to check the child's operator field. In courses/models.py: add ProgramRequirement.clean() to validate operator_value at the model level and raise descriptive ValidationError messages for non-numeric or <1 values. These changes prevent invalid/negative elective minimums at both form and model layers.
How can this be tested?
Attempt to create a new program or edit an existing program. Enter a negative number for the "minimum number" option in the electives section of the program in Django Admin.