Skip to content

Release 0.182.0#2978

Merged
odlbot merged 18 commits into
releasefrom
release-candidate
Apr 8, 2026
Merged

Release 0.182.0#2978
odlbot merged 18 commits into
releasefrom
release-candidate

Conversation

@odlbot
Copy link
Copy Markdown
Contributor

@odlbot odlbot commented Apr 7, 2026

Tobias Macey

renovate[bot]

renovate Bot and others added 18 commits March 29, 2026 10:06
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Adds the drf-serializer-orm-check hook (mirroring the definition from
mitodl/ol-django) to detect Django ORM queries inside DRF serializer
methods (N+1 risk). Uses repo: local so pre-commit only installs
mitol-drf-lint without attempting to pip-install the ol-django workspace
root (which has internal workspace dependencies unavailable on PyPI).

Generates an initial baseline file (drf_lint_baseline.json) recording
existing violations so the hook only flags new issues going forward.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to 0.182.0 and includes a wide range of dependency updates for both Python and Node.js environments. A significant addition is the implementation of a new pre-commit hook, drf-serializer-orm-check, designed to detect N+1 query risks in Django Rest Framework serializers, supported by a baseline file for existing issues. Feedback suggests pinning the version of the mitol-drf-lint dependency within the pre-commit configuration to ensure consistency with the development environment.

Comment thread .pre-commit-config.yaml
Comment on lines +123 to +124
additional_dependencies:
- mitol-drf-lint
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It is recommended to pin the version of mitol-drf-lint in the additional_dependencies list to match the version used in the project's development dependencies (as seen in pyproject.toml). This ensures that the pre-commit hook runs with a consistent version across different environments and prevents unexpected failures if a new version of the linter is released with breaking changes or new rules.

    additional_dependencies:
    - mitol-drf-lint==2026.4.2

@odlbot odlbot merged commit dc466ad into release Apr 8, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants