Make $scope variable available to commands#12
Open
lethosor wants to merge 1 commit into
Open
Conversation
lethosor
commented
May 30, 2025
| vars['tab_size'] = str(tab_size) | ||
| vars['indent'] = indent | ||
| vars['scope'] = view_scope(view) | ||
| vars.update(os.environ) |
Contributor
Author
There was a problem hiding this comment.
I think there is a possible improvement here where os.environ could be given lowest priority. Right now it is given highest priority, so e.g. if someone happens to have an environment variable named file, $file in formatter commands would expand to that, rather than the value returned from view.window().extract_variables() here. I'm not sure when this behavior would be desirable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to configure the same formatter for multiple scopes and change its behavior based on the scope as determined by Sublime, rather than the file extension. This is useful e.g. for files that lack an extension but whose language is known to Sublime.
Inspired by #11, although it may not completely address that use-case.