Conversation
5 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial FreeBSD support to the project by extending the platform selection and command generation logic to handle FreeBSD as a target operating system.
- Added FreeBSD as a selectable platform option in the UI
- Implemented FreeBSD-specific command generation logic for human deployment
- Added FreeBSD case handling for command escaping patterns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| break; | ||
| case "freebsd": | ||
| baseHuman = 'curl -sk -o \''+humanName+'.tar.gz\' -X POST -H \'file:'+humanName+'.tar.gz\' '+http+'/file/download 2>&1 && mkdir \''+humanName+'\' && tar -C \''+humanName+'\' -zxvf \''+humanName+'.tar.gz\' ' + | ||
| ' && virtualenv -p python3.9 \''+humanName+'\' && \''+humanName+'/bin/pip\' install -r \''+humanName+'/requirements.txt\' && \''+humanName+'/bin/python\' \''+humanName+'/human.py\' --clustersize '+taskCount+' ' + |
There was a problem hiding this comment.
The FreeBSD case hardcodes 'python3.9' while other platforms use 'python3'. Consider using 'python3' for consistency unless FreeBSD specifically requires version 3.9.
Suggested change
| ' && virtualenv -p python3.9 \''+humanName+'\' && \''+humanName+'/bin/pip\' install -r \''+humanName+'/requirements.txt\' && \''+humanName+'/bin/python\' \''+humanName+'/human.py\' --clustersize '+taskCount+' ' + | |
| ' && virtualenv -p python3 \''+humanName+'\' && \''+humanName+'/bin/pip\' install -r \''+humanName+'/requirements.txt\' && \''+humanName+'/bin/python\' \''+humanName+'/human.py\' --clustersize '+taskCount+' ' + |
| case "freebsd": | ||
| command = command.replace(/\\/g, '\\\\'); | ||
| command = command.replace(/"/g, '\\\"'); | ||
| break; |
There was a problem hiding this comment.
Remove trailing whitespace after 'break;'
Suggested change
| break; | |
| break; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a initial support for FreeBSD
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: