ci: fix update-dist checkout for fork PRs#107
Merged
Conversation
The previous config used `ref: ${{ github.event.pull_request.head.ref }}`
which doesn't resolve for cross-repo (forked) PRs, causing checkout to
fail. Drop the ref so checkout uses the default merge ref, which is
fetched for both same-repo and forked PRs. Also unquote fetch-depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref: ${{ github.event.pull_request.head.ref }}from the checkout step inupdate-dist.yml. That ref doesn't resolve for cross-repo (forked) PRs and breaks the job (e.g. job71128207893).fetch-depth: 0.With this change,
actions/checkout@v5uses the default merge ref, which is fetched for both same-repo and forked PRs.Test plan
Update distworkflow on PR fix: bump axios to 1.15.0 to address CVE-2025-62718 and issue #103 #106 (forked PR —clutester:fix/axios-cve-update) and confirm the checkout step succeeds.