feat: add ability YAML file upload UI#97
Open
deacon-mp wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI support for importing ability definitions from YAML into the Abilities view, aligning with the existing payload upload modal pattern and targeting a new backend upload endpoint.
Changes:
- Adds an “Import” button to
AbilitiesViewto open an ability-import modal. - Introduces
ImportAbilityModalfor selecting and uploading.yml/.yamlfiles. - Adds
abilityStore.uploadAbility()and a new modal flag undercoreDisplayStore.modals.abilities.showImport.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/views/AbilitiesView.vue | Adds Import button and includes the new import modal in the view. |
| src/stores/coreDisplayStore.js | Adds modals.abilities.showImport state for controlling the new modal. |
| src/stores/abilityStore.js | Adds uploadAbility() action that POSTs the YAML as multipart form data and refreshes abilities. |
| src/components/abilities/ImportAbilityModal.vue | New modal component for selecting and uploading an ability YAML file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await this.getAbilities($api); | ||
| return response; | ||
| } catch(error) { | ||
| console.error("Error uploading ability.", error); |
Comment on lines
+27
to
+34
| async function submitFile($event) { | ||
| const file = input.value.files[0]; | ||
| await abilityStore.uploadAbility($api, file); | ||
|
|
||
| fileName.value = fileUploadPlaceholder; | ||
| isFileSelected.value = false; | ||
| modals.value.abilities.showImport = false; | ||
| } |
| } | ||
| } | ||
|
|
||
| async function submitFile($event) { |
6 tasks
Contributor
All tests completed on my end without issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR
feat/ability-yaml-uploadfor the backend endpointTest plan