removes a usage of the subst tactic, relying on idiomatic ssreflect#1
Open
ybertot wants to merge 4 commits intomituharu:solve_Qint_spanfrom
Open
removes a usage of the subst tactic, relying on idiomatic ssreflect#1ybertot wants to merge 4 commits intomituharu:solve_Qint_spanfrom
ybertot wants to merge 4 commits intomituharu:solve_Qint_spanfrom
Conversation
4 tasks
CohenCyril
reviewed
Mar 29, 2024
| move SE : (\matrix_(i < m, j < _) coord (vbasis <<s>>) j s`_i) => S. | ||
| move rE : (\rank S) => r; move kE : (m - r)%N => k. | ||
| have Dm: (m = k + r)%N by rewrite -kE -rE subnK ?rank_leq_row. | ||
| move: s s_s s_Zs s_v S SE rE kE; rewrite Dm=> s s_s s_Zs s_v S SE rE kE. |
There was a problem hiding this comment.
Suggested change
| move: s s_s s_Zs s_v S SE rE kE; rewrite Dm=> s s_s s_Zs s_v S SE rE kE. | |
| rewrite Dm in s s_s s_Zs s_v S SE rE kE *. |
|
I cherry-picked the commits and addressed the comment, so that the review can take place on the original PR and this one can be closed. |
Tragicus
force-pushed
the
solve_Qint_span
branch
3 times, most recently
from
667540b to
af62356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
style improvement, avoiding tactics remember and subst
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 1.X
TODO: MC-1 portto make sure someone ports this PR tothe
mathcomp-1branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.