build(spotbugs): suppress CT_CONSTRUCTOR_THROW for three abstract class#821
Merged
Conversation
…nd constructor" This reverts commit 71fd80e.
…sses Suppress CT_CONSTRUCTOR_THROW for AbstractWeatherContainerParser, AbstractWeatherCodeParser, and AbstractTrend. All three are abstract (non-final) classes, but the finalizer-attack vector is not exploitable: no finalize() methods exist in the codebase, all concrete subclasses are final, no security-sensitive state is involved, and Java 21 deprecates finalization. Revert 71fd80e restored Objects.requireNonNull in AbstractTrend as good defensive practice; the suppression allows it without CI failure.
|
Please check on sonarcloud https://sonarcloud.io/project/pull_requests_list?id=io.github.mivek%3AmetarParser that the PR does not add any issue. |
|
|
🎉 This PR is included in version 3.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build(spotbugs): suppress CT_CONSTRUCTOR_THROW for three abstract cla…
…sses
Suppress CT_CONSTRUCTOR_THROW for AbstractWeatherContainerParser,
AbstractWeatherCodeParser, and AbstractTrend.
All three are abstract (non-final) classes, but the finalizer-attack
vector is not exploitable: no finalize() methods exist in the codebase,
all concrete subclasses are final, no security-sensitive state is
involved, and Java 21 deprecates finalization.