Doesn't pickup changes in newly created directories with Linux::Inotify2#10
Open
cnmota wants to merge 2 commits intomiyagawa:masterfrom
Open
Doesn't pickup changes in newly created directories with Linux::Inotify2#10cnmota wants to merge 2 commits intomiyagawa:masterfrom
cnmota wants to merge 2 commits intomiyagawa:masterfrom
Conversation
Author
|
Another issue that I ran into was, If you declare a folder to watch that has empty subfolders those subfolders will not be monitored since the _file_scan function is discarding them. I made a hack to fix this, don't know if it is good code, probably it could be a lot better but I am not very familiar with File::Find Fix is on the second commit |
Owner
|
Can you update a unit test to address this? |
Author
|
Will try to, never did one, let me read about it and will do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Believe this fixes it injecting new dirs into the watcher