Fix watching specific files on windows#23
Open
mgreter wants to merge 2 commits intomiyagawa:masterfrom
Open
Conversation
mgreter
force-pushed
the
bugfix/file-watch-windows
branch
2 times, most recently
from
2bc6942 to
56d2f9e
Compare
When you are only watching specific file paths, you get change events for all files in the same directory. On linux only changes to watched files get reported.
mgreter
force-pushed
the
bugfix/file-watch-windows
branch
from
56d2f9e to
1ccdd6a
Compare
Author
|
Added some additional optimizations to utilize resources a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should hopefully fix #16
I only tested linux vs windows behavior
When you are only watching specific file paths, you
get change events for all files in the same directory.
On linux only changes to watched files get reported.
When watching directories you still get all change events!