support watching plain files with Linux::Inotify2#7
Open
sunnavy wants to merge 4 commits intomiyagawa:masterfrom
Open
support watching plain files with Linux::Inotify2#7sunnavy wants to merge 4 commits intomiyagawa:masterfrom
sunnavy wants to merge 4 commits intomiyagawa:masterfrom
Conversation
don't add parent dir into %map if the path is a plain file.
two $fp in $map{$fp}{$fp} is to make structure of %map consistent.
Owner
|
I cannot merge this unless it has a unit test to verify the bug. |
Author
|
test was just added :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed a bug in Filesys-Notify-Simple that causes Linux::Inotify2 watches plain files' parent dirs instead of themselves.