Skip to content

Add stream support#8

Open
randoms wants to merge 2 commits into
mjumbewu:masterfrom
randoms:master
Open

Add stream support#8
randoms wants to merge 2 commits into
mjumbewu:masterfrom
randoms:master

Conversation

@randoms
Copy link
Copy Markdown

@randoms randoms commented Jul 28, 2017

The proxy cannot be used to download large files right now, use http stream to solve the problem.

@mjumbewu
Copy link
Copy Markdown
Owner

mjumbewu commented Aug 7, 2017

This looks good, but do you know whether StreamingHttpResponse will work for all cases that HttpResponse worked?

@randoms
Copy link
Copy Markdown
Author

randoms commented Aug 8, 2017

I am not sure. But I reviewed the code of HttpResponse and HttpStreamResponse, it seems to be OK. It's better to have some test case to verify that. I will find some time to do that.

@mjumbewu
Copy link
Copy Markdown
Owner

mjumbewu commented Aug 8, 2017

That would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants