Skip to content

Added support for XLS#29

Open
cescp wants to merge 1 commit into
mjumbewu:masterfrom
cescp:master
Open

Added support for XLS#29
cescp wants to merge 1 commit into
mjumbewu:masterfrom
cescp:master

Conversation

@cescp

@cescp cescp commented Feb 10, 2015

Copy link
Copy Markdown

Based on xlrd, xlwt: http://www.python-excel.org/

@mjumbewu

mjumbewu commented Mar 3, 2015

Copy link
Copy Markdown
Owner

Ooh, @cescp I just saw this. Thanks! Lots of good stuff here. If you can, would you do me a favor and:

  1. add xlrd==0.9.3 and xlwt==0.7.5 to the requirements.txt file (as they're now required for tests to pass), and
  2. add a test (or more) for XLS parsing, maybe based off of tests.TestCSVParser.test_parse_two_lines_flat_csv. There's some refactoring that I'd like to do in the parsers and I want to make sure I wouldn't break what you've contributed.

@JocelynDelalande

Copy link
Copy Markdown

Please make it a different module, that's kinda bloating the lib with dependencies unrelated to CSV.

@danilke

danilke commented Jun 5, 2017

Copy link
Copy Markdown

Hi, it will be so great if your it will have support for XLS!

@danilke danilke mentioned this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants