Skip to content

Add column header setting#80

Open
liamdiprose wants to merge 7 commits into
mjumbewu:masterfrom
liamdiprose:column-header-setting
Open

Add column header setting#80
liamdiprose wants to merge 7 commits into
mjumbewu:masterfrom
liamdiprose:column-header-setting

Conversation

@liamdiprose

Copy link
Copy Markdown

This PR adds the ability to define the CSV column order from within the code
Currently, the CSV Parser assumes the first row of CSV data contains the column names.

This PR adds the ability to define the column names from the ViewSet class:

class CSVEndpoint(viewsets.ModelViewSet):
    serializer_class = CSVSerializer
    parser_classes = (CSVParser,)

    csv_header = ("time", "temperature")

There are still a few small things I would like to address before this is merged. Namely

  • Is the viewset class the appropriate place to define the csv_header variable?
  • Testing? I've only manually-tested this with my own project so far.
  • Code style, this is quick and dirty; is there more django-y way of doing this?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant