Remove ztd-cli after Ashiba migration#860
Merged
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 288 files, which is 138 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (12)
📒 Files selected for processing (288)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rawsql-ts/ztd-cliworkspace package now that the CLI surface has moved to Ashiba (@ashiba-ts/cli).Verification
pnpm typecheckpnpm --filter rawsql-ts test -- DynamicQueryBuilder.test.ts DynamicFilterRoutingDogfooding.test.tspnpm --filter @rawsql-ts/testkit-sqlite run testpnpm --filter @rawsql-ts/ddl-docs-cli run test -- check.integration.test.tspnpm buildpnpm docs:build(succeeded with existing TypeDoc warnings and Vite chunk-size warning)pnpm verify:published-package-modepnpm testpnpm lintpnpm typecheck,pnpm test,pnpm build, andpnpm lintrgconfirmed remainingztd-clireferences are limited to migration/extraction notes outside changelogsMerge Readiness
Tracking issue: Not required; no baseline exception requested.
Scoped checks run: Full local checks listed in Verification.
Why full baseline is not required: Full local workspace checks were run; no exception requested.
Self Review
Self-review workflow: developer-pre-pr-retro-gate and developer-self-review.
Self-review result: No blockers found; intentional remaining ztd-cli mentions are migration/extraction notes only.
Concept-review workflow: Package-boundary review against the README package map, Ashiba ownership boundary, and retained rawsql-ts package responsibilities.
Concept-review result: No boundary violations found; rawsql-ts keeps parser/formatter/testkit/sql-grep/DDL-docs packages while Ashiba owns the removed CLI/scaffold lifecycle.
CLI Surface Migration
No-migration rationale: The CLI has already moved to Ashiba; this PR removes the obsolete rawsql-ts package and stale gates rather than adding a new rawsql-ts CLI surface.
Upgrade note: Use Ashiba (
@ashiba-ts/cli) for SQL-first scaffolding, query inspection, optional-condition maintenance, and project lifecycle workflows.Deprecation/removal plan or issue: Removal is implemented in this PR after the Ashiba rebrand/merge.
Docs/help/examples updated: README, VitePress navigation, guide pages, benchmark notes, and command hints now point to Ashiba or reusable rawsql-ts packages.
Release/changeset wording: No changeset added because the obsolete workspace package is removed from this repository rather than changed for a rawsql-ts package release.
Scaffold Contract Proof
No-proof rationale: rawsql-ts no longer owns ztd-cli scaffold generation after the Ashiba move.
Non-edit assertion: Existing rawsql-ts reusable package behavior is preserved; ztd-cli scaffold source/templates/tests were removed.
Fail-fast input-contract proof:
pnpm test, targeted tests, and published-package smoke passed without the removed CLI package.Generated-output viability proof: Not applicable to rawsql-ts after scaffold ownership moved to Ashiba; transfer docs generation still passed through
pnpm docs:build.