Open
Conversation
mblomdahl
requested changes
Sep 22, 2022
Member
mblomdahl
left a comment
mblomdahl
left a comment
There was a problem hiding this comment.
Hi Bulat! This is not mergeable with the upstream branch, and it does not comply with the acceptance criterion listed in PR #8. You need to create a new branch from latest main and add changes incrementally in meaningful commits so that contributions can be assessed and understood. We can not have 30 000 lines of "random stuff" in 1 anonymous commit.
Please check out https://github.com/mkdevops-se/bamboo-ci-health/commits/master for a recent example of structured and documenting commits.
Collaborator
Author
|
Okay Mats! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.