Fix compilation on Windows when using standalone clang#64
Open
deimonn wants to merge 1 commit intomkirchner:masterfrom
Open
Fix compilation on Windows when using standalone clang#64deimonn wants to merge 1 commit intomkirchner:masterfrom
deimonn wants to merge 1 commit intomkirchner:masterfrom
Conversation
Author
|
I just realized (that's what I get for not looking beforehand) that #62 kind of addresses this, although GrimMaple's approach is to bring in I prefer this approach for consistency, but it really is up to preference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to compile
gc.cusing Clang 18.1.8 on Windows (the standalone version from the installer found in LLVM's releases page, not the MSYS2 version; that works fine) generates an "undeclared library function _AddressOfReturnAddress" error when expanding the__builtin_frame_addressmacro.Clang supports the
__builtin_frame_addressbuilt-in on Windows even in the MSVC environment, so the macro doesn't even need to exist when compiling with it.This PR fixes the issue with a little check to omit the macro when
__clang__is defined.