Skip to content

Started working on the custom speech api#3

Open
mikkoh wants to merge 2 commits into
mko:masterfrom
mikkoh:master
Open

Started working on the custom speech api#3
mikkoh wants to merge 2 commits into
mko:masterfrom
mikkoh:master

Conversation

@mikkoh
Copy link
Copy Markdown
Contributor

@mikkoh mikkoh commented Jul 29, 2014

I've started implementing the custom speech api.

Unfortunately the project I've been working on most likely wont use this anymore but I figure you might want this source code anyway.

It may seem that there are a lot changes here. Mostly I just made the quotation marks consistent throughout the JS file.

Something I've found wierd about this API is that you require a different access token for the custom speech and regular speech. This might become a consideration going forward cause currently you'd be instantiating two instances of watson-js in order to use functionality. It might be good to save the access token per scope.

@mko
Copy link
Copy Markdown
Owner

mko commented Jul 29, 2014

As I haven't used the Speech API since 2012, I'd imagine that things have changed a bit. I'll review the code and see if it makes sense to make the modifications you recommended.

I may also ping the good folks at AT&T to see if they have someone willing to be an active maintainer, since not using the API actively has left me with little context for this update.

Thanks for your work on making the API and its Node wrapper better, either way!

Michael Owens
mk@mowens.com
https://mowens.com
@mko

On Jul 29, 2014, at 11:14 AM, Mikko Haapoja notifications@github.com wrote:

I've started implementing the custom speech api.

Unfortunately the project I've been working on most likely wont use this anymore but I figure you might want this source code anyway.

It may seem that there are a lot changes here. Mostly I just made the quotation marks consistent throughout the JS file.

Something I've found wierd about this API is that you require a different access token for the custom speech and regular speech. This might become a consideration going forward cause currently you'd be instantiating two instances of watson-js in order to use functionality. It might be good to save the access token per scope.

You can merge this Pull Request by running

git pull https://github.com/MikkoH/watson-js master
Or view, comment on, or merge it at:

#3

Commit Summary

Started working on the custom speech api
File Changes

M lib/watson.js (86)
Patch Links:

https://github.com/mko/watson-js/pull/3.patch
https://github.com/mko/watson-js/pull/3.diff

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants