Conversation
App.async_create_window() does not exist in iterm2 v2.13. The correct API is iterm2.Window.async_create(connection, profile, command), which is a static method on the Window class. This also passes the --command flag directly to the iterm2 API instead of manually sending text via async_send_text after window creation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Click derives kwarg names from option strings: --session -> `session`, --all -> `all`, --window -> `window`. But shortcut functions declared mismatched parameter names (session_id, all_sessions, window_id), causing TypeErrors on invocation. Fixed by either renaming function params to match the Click-derived names, or adding explicit Click name arguments (e.g. "--all", "-a", "all_sessions") where the Python kwarg must differ from the option. Affected shortcuts: send, run, split, vsplit, clear, newtab. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
@urjitbhatia However, these have already been fixed independently on the main branch (commits 36823cd and eb7ad24). Could you verify that and close this PR if so? Thanks again for taking the time to look into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
A bunch of the iTerm API calls were falling. They're pretty much fixed here. And commands like new session, send message etc are fully working.