Add support for numpy scalar and boolean mask indexing#2713
Closed
cetagostini wants to merge 1 commit intoml-explore:mainfrom
Closed
Add support for numpy scalar and boolean mask indexing#2713cetagostini wants to merge 1 commit intoml-explore:mainfrom
cetagostini wants to merge 1 commit intoml-explore:mainfrom
Conversation
Enhanced indexing logic to handle numpy scalar types and boolean masks in mlx arrays. Updated C++ implementation to convert boolean masks to integer indices and support numpy scalar types in indexing and assignment. Added comprehensive tests for numpy scalar and boolean mask indexing behaviors.
Author
|
Hey MLX team, thanks for the awesome library. Opening this to actually get better support of certain indexing things into pytensor, which allow now MLX backend :) cc: @awni @angeloskath |
Author
|
Hey guys, did you had a chance to take a look here? @awni @angeloskath |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enhanced indexing logic to handle numpy scalar types and boolean masks in mlx arrays. Updated C++ implementation to convert boolean masks to integer indices and support numpy scalar types in indexing and assignment. Added comprehensive tests for numpy scalar and boolean mask indexing behaviors.
Solve issue: #2710
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes