fix(ci): use correct rust-toolchain action and venv for maturin#1
Merged
Conversation
farhan-syah
commented
Nov 26, 2025
farhan-syah
commented
Member
- Replace dtolnay/rust-action with dtolnay/rust-toolchain
- Create venv for maturin develop command
- Use .venv/bin/python for test step
- Replace dtolnay/rust-action with dtolnay/rust-toolchain - Create venv for maturin develop command - Use .venv/bin/python for test step
- Pin Python 3.12 in test job (runner default 3.14 exceeds PyO3 max 3.13) - Apply rustfmt formatting fixes - Fix clippy collapsible_if warning - Add pre-commit hook for local development
…forms - Consolidate clippy and rustfmt into single lint job - Add PyO3 Python environment configuration for Ubuntu, macOS, and Windows - Configure LIBRARY_PATH on macOS to resolve linker errors with Python framework - Restore full Python tests with tiktoken comparison This resolves macOS build failures caused by missing Python framework linking.
Update macOS PyO3 configuration to use the standard -undefined dynamic_lookup linker flag for Python extension modules. Add DYLD_LIBRARY_PATH environment variable alongside LIBRARY_PATH for proper runtime library resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.