fix: lower python 3.14 scikit-learn floor#9
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Python 3.14 installability by lowering the scikit-learn minimum version for Python 3.14 and adjusts correlation feature type checking to be compatible with pandas 3.0 dtype behavior.
Changes:
- Lowered the Python 3.14
scikit-learnminimum from>=1.8.0to>=1.7.2in bothpyproject.tomlanduv.lock. - Updated correlation feature validation to use
pandas.api.types.is_numeric_dtypeinstead ofnumpy.issubdtypefor more robust dtype handling (notably for pandas extension dtypes).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Aligns the locked dependency metadata with the lowered Python 3.14 scikit-learn floor. |
src/ml4t/engineer/relationships/correlation.py |
Fixes numeric dtype detection to avoid pandas 3.0 dtype/extension dtype issues during feature validation. |
pyproject.toml |
Lowers the declared Python 3.14 scikit-learn minimum requirement to reduce downstream conflicts. |
CHANGELOG.md |
Documents the Python 3.14 dependency floor adjustment in the release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification