Open
Conversation
|
What do you call "legacy"? Do you mean pre-NT win32 ? |
Owner
|
@NuklearBomb I have some time coming up where I can give this a code review and provide suggestions on how you can take it to completion. It looks like the work was done almost two years ago -- would you be interested in working on it still? I will wait for your go-ahead before reviewing the code. |
|
@mlabbe People and frameworks use your API so yes we are interested in updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested against all tests in the
testsfolder on 32-bit MinGW. I tested by building the source files directly instead of using theMakefile, so I unfortunately cannot provide an updatedMakefile. I was wondering what kind of ideas you have for making an application capable of using eithernfd_winornfd_win_legacybased on what functions are available in the operating system. Let me know if there are any additional changes needed and I'll see what I can do. Thank you for your work on Native File Dialog!