option to disable md5#236
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #236 +/- ##
===========================================
+ Coverage 79.68% 79.71% +0.03%
===========================================
Files 147 147
Lines 13870 13873 +3
===========================================
+ Hits 11052 11059 +7
+ Misses 2818 2814 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a configurable SFTP option to disable rclone’s server-side checksum/hash checks (to support restricted SFTP servers that cannot execute md5sum/sha1sum), exposing it in the UI and validating behavior via unit tests.
Changes:
- Add
disable_server_side_checksumstoSFTPStorageConfigand wire it to rclone’s--sftp-disable-hashcheck. - Add UI field to toggle server-side checksums for SFTP sync locations.
- Add new unit test module covering SFTP config validation and the presence/absence of the rclone flag.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/borgitory/services/cloud_providers/storage/sftp_storage.py |
Adds the config flag and appends --sftp-disable-hashcheck during SFTP sync. |
src/borgitory/templates/partials/cloud_sync/providers/sftp/sftp_fields.html |
Adds a “Server-Side Checksums” selector to the SFTP provider form. |
tests/unit/cloud_providers/test_sftp_storage.py |
Introduces new unit tests for config validation and command construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
closes: #235