Skip to content

option to disable md5#236

Open
mlapaglia wants to merge 2 commits into
developfrom
disable-md5
Open

option to disable md5#236
mlapaglia wants to merge 2 commits into
developfrom
disable-md5

Conversation

@mlapaglia
Copy link
Copy Markdown
Owner

closes: #235

Copilot AI review requested due to automatic review settings May 22, 2026 02:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.71%. Comparing base (0ee810d) to head (6e29ca4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    79.68%   79.71%   +0.03%     
===========================================
  Files          147      147              
  Lines        13870    13873       +3     
===========================================
+ Hits         11052    11059       +7     
+ Misses        2818     2814       -4     
Flag Coverage Δ
e2e 0.00% <0.00%> (ø)
integration 45.85% <33.33%> (-0.01%) ⬇️
unit 71.21% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a configurable SFTP option to disable rclone’s server-side checksum/hash checks (to support restricted SFTP servers that cannot execute md5sum/sha1sum), exposing it in the UI and validating behavior via unit tests.

Changes:

  • Add disable_server_side_checksums to SFTPStorageConfig and wire it to rclone’s --sftp-disable-hashcheck.
  • Add UI field to toggle server-side checksums for SFTP sync locations.
  • Add new unit test module covering SFTP config validation and the presence/absence of the rclone flag.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
src/borgitory/services/cloud_providers/storage/sftp_storage.py Adds the config flag and appends --sftp-disable-hashcheck during SFTP sync.
src/borgitory/templates/partials/cloud_sync/providers/sftp/sftp_fields.html Adds a “Server-Side Checksums” selector to the SFTP provider form.
tests/unit/cloud_providers/test_sftp_storage.py Introduces new unit tests for config validation and command construction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/borgitory/services/cloud_providers/storage/sftp_storage.py
Comment thread src/borgitory/services/cloud_providers/storage/sftp_storage.py
Comment thread src/borgitory/services/cloud_providers/storage/sftp_storage.py
Comment thread tests/unit/cloud_providers/test_sftp_storage.py Outdated
Comment thread tests/unit/cloud_providers/test_sftp_storage.py Outdated
Comment thread tests/unit/cloud_providers/test_sftp_storage.py Outdated
Comment thread tests/unit/cloud_providers/test_sftp_storage.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rclone setting for no md5 hash

3 participants