Refactor distributed module#41
Open
haok1402 wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the distributed training configuration and setup, introducing a configurable timeout and sharding strategy (FSDP vs. HSDP). It also moves the fail-fast exception handling directly into the distributed module and updates the FSDP application logic to support the new sharding strategies. Feedback highlights a potential type mismatch when loading timeouts from JSON, the use of a private PyTorch API (DeviceMesh._concatenate) which may cause future compatibility issues, and a suggestion to improve the readability of the threading exception hook.
haok1402
force-pushed
the
0516-refactor-distributed
branch
from
db1db09 to
2f028ce
Compare
haok1402
force-pushed
the
0516-refactor-distributed
branch
from
2f028ce to
d066629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewords the docstrings across the distributed module for clarity, and switches the operation timeout from an int (seconds) to a timedelta with a 15-minute default.