Skip to content

Reinitialize if optimization fails#130

Open
sethaxen wants to merge 8 commits intomainfrom
trycontinue
Open

Reinitialize if optimization fails#130
sethaxen wants to merge 8 commits intomainfrom
trycontinue

Conversation

@sethaxen
Copy link
Copy Markdown
Member

If for some reason we hit an edge case in the optimizer and an error is thrown, this PR causes Pathfinder to draw a new initialization point and rerun.

This PR makes a breaking changes: if an OptimizationProblem has been provided, its initialization point u0 must be mutable and may be overwritten. This avoids a deepcopy of the OptimizationProblem.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 28, 2023

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (7bc83fb) to head (653cff8).
⚠️ Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
src/singlepath.jl 84.61% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7bc83fb) and HEAD (653cff8). Click for more details.

HEAD has 46 uploads less than BASE
Flag BASE (7bc83fb) HEAD (653cff8)
50 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #130       +/-   ##
===========================================
- Coverage   92.65%   78.15%   -14.51%     
===========================================
  Files          13       13               
  Lines         572      563        -9     
===========================================
- Hits          530      440       -90     
- Misses         42      123       +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants