Fix multi-model accuracy submission bugs and update tests#53
Merged
Conversation
- builder.py: apply _truncate_responses to accuracy/results.json in addition to root results.json; remove _write_accuracy_fallback (it overwrote the truncated file with bare accuracy_scores); fix yaml_dir for accuracy runs so point_N.yaml lands in points/ not accuracy/; fix _write_src to namespace files under src/<model>/ to prevent multi-model collisions - test_builder.py: fix three stale tests that asserted old YAML-in- accuracy-dir behavior; add TestAccuracyResultsTruncation covering the three accuracy workflow scenarios (no accuracy/ subdir, large accuracy/results.json, already-small accuracy/results.json) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
- Rename unused loop variable system_id to _system_id (B007) - Wrap long _write_pareto_entries call to stay under 100 chars (E501) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
For accuracy runs yaml_dir should be result_dir (.../accuracy/) so that point_N.yaml is co-located with the accuracy results, not in points/. Performance runs continue to write their YAML to points/. Update test assertions to match the correct layout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
arav-agarwal2
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builder.py: apply _truncate_responses to accuracy/results.json in addition to root results.json; remove _write_accuracy_fallback (it overwrote the truncated file with bare accuracy_scores); fix yaml_dir for accuracy runs so point_N.yaml lands in points/ not accuracy/; fix _write_src to namespace files under src// to prevent multi-model collisions
test_builder.py: fix three stale tests that asserted old YAML-in- accuracy-dir behavior; add TestAccuracyResultsTruncation covering the three accuracy workflow scenarios (no accuracy/ subdir, large accuracy/results.json, already-small accuracy/results.json)