Skip to content

chore(deps): relax numpy pin to >=1.26.4 for bfcl-eval compatibility #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Palanivelg wants to merge 1 commit into from
Closed

chore(deps): relax numpy pin to >=1.26.4 for bfcl-eval compatibility #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ dependencies = [
"transformers==5.5.0",
# Required by transformers' apply_chat_template
"jinja2==3.1.6",
"numpy==2.4.4",
"numpy>=1.26.4",

@gemini-code-assist gemini-code-assist Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Relaxing the numpy pin to >=1.26.4 allows pip to resolve to either numpy 1.x (when [bfcl] is installed) or numpy 2.x (when it is not). Because numpy 2.0 introduced significant breaking changes, running different major versions of numpy across environments can lead to subtle bugs, API incompatibilities, or non-reproducible benchmark results. To maintain strict environment reproducibility and adhere to the repository's exact-pinning policy, consider pinning numpy to 1.26.4 globally instead.

Suggested change
"numpy>=1.26.4",
"numpy==1.26.4",

"datasets==4.8.4",
"Pillow==12.2.0",
"sentencepiece==0.2.1",
Expand Down
Loading