fix: [release/v0.5] Set warmup salt to true as default#364
Conversation
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
Code Review
This pull request updates the default value of the salt parameter in the warmup configuration from False to True in the schema definition and across the concurrency, offline, and online configuration templates. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Can you push to main as well? |
|
@attafosu FYI |
arekay-nv
left a comment
There was a problem hiding this comment.
Review Council — Multi-AI Code Review
Reviewed by: Codex + Claude | Depth: quick (auto-selected: <200 lines)
Found 1 issue.
Review Council — Multi-AI Code ReviewReviewed by: Codex + Claude | Depth: quick (auto-selected: <200 lines, 1 commit) Found 1 issue — flagged independently by both reviewers (high confidence).
Details:
|
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
|
closing in favor of #365 on main. |
What does this PR do?
Sets warmup salt as true by default. This avoids confusion when warmup is enabled but the intent is not to pre-populate the cache with dataset entries. If that is indeed the intent, then explicitly disabling salt can be used.
Type of change
Related issues
Testing
Checklist