Skip to content

fix: [release/v0.5] Set warmup salt to true as default#364

Closed
arekay-nv wants to merge 5 commits into
release/v0.5from
arekay/set_warmup_salt_true
Closed

fix: [release/v0.5] Set warmup salt to true as default#364
arekay-nv wants to merge 5 commits into
release/v0.5from
arekay/set_warmup_salt_true

Conversation

@arekay-nv

Copy link
Copy Markdown
Collaborator

What does this PR do?

Sets warmup salt as true by default. This avoids confusion when warmup is enabled but the intent is not to pre-populate the cache with dataset entries. If that is indeed the intent, then explicitly disabling salt can be used.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv arekay-nv requested a review from a team as a code owner June 22, 2026 02:48
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default value of the salt parameter in the warmup configuration from False to True in the schema definition and across the concurrency, offline, and online configuration templates. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@nvzhihanj

Copy link
Copy Markdown
Collaborator

Can you push to main as well?

@github-actions github-actions Bot requested a review from nvzhihanj June 22, 2026 02:50
@nvzhihanj

Copy link
Copy Markdown
Collaborator

@attafosu FYI

@arekay-nv arekay-nv left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Council — Multi-AI Code Review

Reviewed by: Codex + Claude | Depth: quick (auto-selected: <200 lines)

Found 1 issue.

Comment thread src/inference_endpoint/config/schema.py
@arekay-nv

arekay-nv commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Review Council — Multi-AI Code Review

Reviewed by: Codex + Claude | Depth: quick (auto-selected: <200 lines, 1 commit)

Found 1 issue — flagged independently by both reviewers (high confidence).

# File Line Severity Category Reviewer(s) Summary
1 src/inference_endpoint/config/schema.py 513 high testing Both test_defaults asserts cfg.salt is False — will fail after this default change

Details: tests/unit/commands/test_benchmark.py:417 has assert cfg.salt is False which now fails (WarmupConfig().salt returns True). Update to assert cfg.salt is True. Test failure confirmed locally.

Codex note: The --no-warmup-salt CLI negation flag is automatically generated by cyclopts and confirmed present, so users who want the old behavior can opt out.

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv arekay-nv changed the title Set warmup salt to true as default fix: [release/v0.5] Set warmup salt to true as default Jun 22, 2026
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv

Copy link
Copy Markdown
Collaborator Author

closing in favor of #365 on main.

@arekay-nv arekay-nv closed this Jun 22, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants