Skip to content

Add better logging for performance range mode testing #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arav-agarwal2 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add better logging for performance range mode testing #2560

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ee8fb9
Add shebangs in bulk pre-testing
arav-agarwal2 Feb 2, 2026
3099c81
Update to exec mode
arav-agarwal2 Feb 3, 2026
9ab2a16
Revert "Add shebangs in bulk pre-testing"
arav-agarwal2 Mar 10, 2026
c74240c
Revert "Update to exec mode"
arav-agarwal2 Mar 10, 2026
9b36a1a
Update logging for loadgen for more verbose performance range logging
arav-agarwal2 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 47 additions & 4 deletions loadgen/loadgen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,10 +828,53 @@ PerformanceSummary FindPeakPerformanceBinarySearch(

std::string tmp;
if (m_perf_summary.PerfConstraintsMet(&tmp)) {

LogDetail([l_field =
find_peak_performance::ToStringPerformanceField<scenario>(
l_perf_summary.settings),
u_field =
find_peak_performance::ToStringPerformanceField<scenario>(
u_perf_summary.settings),
m_field =
find_peak_performance::ToStringPerformanceField<scenario>(
m_settings)](AsyncDetail& detail) {
#if USE_NEW_LOGGING_FORMAT
MLPERF_LOG(
detail, "generic_message",
"FindPeakPerformanceBinarySearch: Mid value satisfies performance constraints, new bounds are [" +
m_field + ", " + u_field + ")");
#else
detail(
"FindPeakPerformanceBinarySearch: Mid value satisfies performance constraints, new bounds are [" + m_field + ", " + u_field + "]");
#endif
});

return FindPeakPerformanceBinarySearch<scenario>(
sut, qsl, sequence_gen, performance_set, m_perf_summary,
u_perf_summary);
} else {


LogDetail([l_field =
find_peak_performance::ToStringPerformanceField<scenario>(
l_perf_summary.settings),
u_field =
find_peak_performance::ToStringPerformanceField<scenario>(
u_perf_summary.settings),
m_field =
find_peak_performance::ToStringPerformanceField<scenario>(
m_settings)](AsyncDetail& detail) {
#if USE_NEW_LOGGING_FORMAT
MLPERF_LOG(
detail, "generic_message",
"FindPeakPerformanceBinarySearch: Mid value does not satisfy performance constraints, new bounds are [" +
l_field + ", " + m_field + ")");
#else
detail(
"FindPeakPerformanceBinarySearch: Mid value does not satisfy performance constraints, new bounds are [" + l_field + ", " + m_field + "]");
#endif
});

return FindPeakPerformanceBinarySearch<scenario>(
sut, qsl, sequence_gen, performance_set, l_perf_summary,
m_perf_summary);
Expand Down Expand Up @@ -1048,11 +1091,11 @@ void FindPeakPerformanceMode(SystemUnderTest* sut, QuerySampleLibrary* qsl,
u_perf_summary.settings)](AsyncDetail& detail) {
#if USE_NEW_LOGGING_FORMAT
MLPERF_LOG(detail, "generic_message",
"FindPeakPerformance: Found boundaries: [" + l_field + ", " +
u_field + ")");
"FindPeakPerformance: Found initial performance boundaries: [" + l_field + ", " +
u_field + "). Proceeding to find peak performance number.");
#else
detail("FindPeakPerformance: Found boundaries: [" + l_field + ", " +
u_field + ")");
detail("FindPeakPerformance: Found initial performance boundaries: [" + l_field + ", " +
u_field + "). Proceeding to find peak performance number.");
#endif
});

Expand Down
Loading