Remove old submodule#2594
Open
pgmpablo157321 wants to merge 5 commits into
Open
Conversation
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Contributor
|
Is Bert removed from v6.1? |
Contributor
Nope, Bert still in v6.1 Edge. |
nvzhihanj
approved these changes
Jun 2, 2026
hanyunfan
previously approved these changes
Jun 3, 2026
Contributor
|
@hanyunfan Thank you. But then this submodule being removed is required right? |
Contributor
Which submodule, the automation one? |
Contributor
|
Hi @hanyunfan , the deeplearningexamples submodule is being removed in this PR. The test for bert fails due to this reason. |
Contributor
Not sure what the deeplearningexamples submodule is for, but we need to keep bert, so it is a dependency of Bert (Don't understand why) we should keep it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.