Update logging for gpt-oss-20b#447
Merged
ShriyaRishab merged 5 commits intomlcommons:masterfrom Mar 4, 2026
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Contributor
|
@suachong - do you have RCP epochs for at least one of the batch sizes? |
| REQ: AT_LEAST_ONE | ||
| CHECK: | ||
| - "'epoch_num' in v['metadata']" | ||
| ATLEAST_ONE_CHECK: "(v['value'] <= 3.34) and v['value'] > 0.0" No newline at end of file |
Contributor
There was a problem hiding this comment.
Can you add the rest of the parameters also but don't add a specific check?
Similar to this - https://github.com/mlcommons/logging/blob/master/mlperf_logging/compliance_checker/training_6.0.0/open_llama31_405b.yaml
ShriyaRishab
previously approved these changes
Feb 26, 2026
Contributor
|
@suachong please address the merge conflicts and open issues so we can merge it today |
ShriyaRishab
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.